Skip to content

[RUST] Update Cargo crate authors - #2500

Merged
nhynes merged 1 commit into
masterfrom
update-rust-contribs
Jan 24, 2019
Merged

[RUST] Update Cargo crate authors#2500
nhynes merged 1 commit into
masterfrom
update-rust-contribs

Conversation

@nhynes

@nhynes nhynes commented Jan 23, 2019

Copy link
Copy Markdown
Member

This PR updates the Cargo.toml authors in preparation for #2292 and #2466. This, and the rest of the field, will be visible on crates.io).

@ehsanmok

ehsanmok commented Jan 23, 2019

Copy link
Copy Markdown
Contributor

@nhynes I don't know if it's customary in apache projects but may I propose the initiator be added along with TVM contributors in author name and apache email for email part?

@nhynes

nhynes commented Jan 24, 2019

Copy link
Copy Markdown
Member Author

propose the initiator be added along with TVM contributors

I'm in favor of following the existing convention in the rest of the TVM repo, which is to just say Contributors. The only reasons to add initiator are code ownership and recognition of contribution. Git automatically tracks both and the project already has a protocol for codeowners. Also, just having "Contributors" keeps things simple and solves the problem of making sure that all parties--author, reviewers, and design shepherds--are credited equally.

@nhynes
nhynes merged commit d08941f into master Jan 24, 2019
@nhynes
nhynes deleted the update-rust-contribs branch January 24, 2019 18:50
@ehsanmok

Copy link
Copy Markdown
Contributor

@nhynes thanks for the explanations! I'm in favor of that too 👍 (however I meant more of possible accountability issue later on which is actually hard to enforce in OSS projects).

What about email? (cc @tqchen)

@tqchen

tqchen commented Jan 24, 2019

Copy link
Copy Markdown
Member

Adding list of personal emails and accounts to the list creates a question of maintaining it, and one main question we need to ask is would it create barriers for new contributors?
I think a better way might be just following the Apache way of recognizing contributions, e.g. merit-based, reviewer list and committer-ships.

The PMC is actively working hard to make sure the community guideline is enforced :)

@ehsanmok

Copy link
Copy Markdown
Contributor

@tqchen sure, makes sense! so what email we should use in Cargo.toml? tvm@apache.org ?

@tqchen

tqchen commented Jan 24, 2019

Copy link
Copy Markdown
Member

We are still in the process of incubator proposals, so we can use a temporary placeholder email of the current maintainer if necessary.

Anthony-Mai pushed a commit to Anthony-Mai/tvm that referenced this pull request Jan 25, 2019
zhiics pushed a commit to zhiics/tvm that referenced this pull request Jan 30, 2019
merrymercy pushed a commit to merrymercy/tvm that referenced this pull request Feb 18, 2019
wweic pushed a commit to neo-ai/tvm that referenced this pull request Feb 20, 2019
wweic pushed a commit to neo-ai/tvm that referenced this pull request Feb 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants