Skip to content

[Bug][VM] If not allocate on stack, VM runtime cannot work? #8977

Description

@zhanghaohit

In src/tir/transforms/lower_tvm_builtin.cc

    if (device_type_.defined()) {
      if (const auto* dev_type = device_type_.as<IntImmNode>()) {
        if (dev_type->value == kDLCPU) {
          int32_t constant_size = op->constant_allocation_size();
          if (constant_size > 0 && constant_size * nbytes < runtime::kMaxStackAlloca) {
            return stmt;
          }
        }
      }
    }

If the condition if (constant_size > 0 && constant_size * nbytes < runtime::kMaxStackAlloca) is not true, the generated IR cannot work in VM runtime. Please see the detailed explanation here #8274.

The bug is not triggering any problem for now, since this condition may be always true in our test. I'm not very sure this is a bug, but we need deeper investigation on this.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    executor:vmruntime components of VM flow. src/runtime/vm, python/tvm/runtime/vm.pyflow:vmtype: bug

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions