Repository navigation
THRIFT-6392: Stop the D fastest client pool hanging when a child fails early - #3972
Merged
Merged
Conversation
…s early Client: d The fastest pool stopped registering completion callbacks once it saw a child future that had already completed, assuming that child had set the result. A child that failed with an RPC fault does not set it, so the remaining children were never counted and the pool's future never completed. client_pool_test hit this in its all-clients-fail case whenever the 1 ms server answered before the pool was constructed. client_pool_test now bounds every client wait and socket read, and CI caps the D check step, so a future hang fails in seconds rather than holding the job until its 60 minute timeout. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
mergeable
Bot
added
d
slachiewicz
marked this pull request as ready for review
September 28, 2026 12:07
slachiewicz
requested review from
Jens-G,
fishy and
jimexist
as code owners
September 28, 2026 12:07
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
THRIFT-6392
The fastest pool stopped registering completion callbacks once it saw a child future that had already completed, assuming that child had set the result. A child that failed with an RPC fault does not set it, so the remaining children were never counted and the pool's future never completed.
client_pool_testhit this in its all-clients-fail case whenever the 1 ms server answered before the pool was constructed, which is the intermittentlib-djob timeout.client_pool_testnow bounds every client wait and socket read, and CI caps the D check step at 15 minutes, so a future hang fails in seconds rather than holding the job until its 60 minute timeout.Verified: the new unittest fails before the fix and passes after; 30 local runs of
client_pool_test(LDC, macOS arm64) went from 5 hangs to none.