Repository navigation
THRIFT-6385: Skip the RLIMIT_AS test case where the limit is unsupported - #3969
Open
slachiewicz wants to merge 1 commit into
Open
slachiewicz wants to merge 1 commit into
slachiewicz wants to merge 1 commit into
Conversation
Client: cpp macOS rejects an RLIMIT_AS limit with EINVAL, so the child always exited with 2 and the case failed there. The child now exits with 77 in that case and the case reports that it has nothing to check; any other setrlimit failure still fails it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
macOS rejects an
RLIMIT_ASlimit withEINVAL, soallocation_failure_on_the_io_thread_does_not_end_the_processalways failed there. The child now exits with 77 in that case, and the test case reports that it has nothing to check; any othersetrlimitfailure still fails it. Linux accepts the limit, so the case runs there as before.Verified: TNonblockingServerTest passes on macOS 27 (arm64).