Repository navigation
THRIFT-6080: Stop copying a binary field on every call to its byte[] getter - #3966
Open
slachiewicz wants to merge 1 commit into
Open
slachiewicz wants to merge 1 commit into
slachiewicz wants to merge 1 commit into
Conversation
…getter Client: java The generated byte[] getX() right-sized the field and stored it through setX(), which copies again with copyBinary, so every call copied the bytes although it returns the field's own array either way. It now assigns the right-sized buffer directly, as Apache Accumulo already does by patching the generated code. Union getters and bufferForX() are unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The generated
byte[] getX()now assigns the right-sized buffer directly instead of going throughsetX(), whosecopyBinarycopied the bytes on every call. The method still returns the field's own array, as before. This is the part of THRIFT-6080 that changes no behaviour; union getters,bufferForX()andunsafe_binariesare left for the discussion on the ticket.Verified: the new TestStruct case fails without the change;
gradle testin lib/java → 379 passed.