Repository navigation
THRIFT-6380: Keep configure and build output out of the source tarball - #3960
Open
slachiewicz wants to merge 1 commit into
Open
slachiewicz wants to merge 1 commit into
slachiewicz wants to merge 1 commit into
Conversation
Client: build Directories that EXTRA_DIST names whole also carry what configure, the build and rebar3 left in them, so the 0.25.0 tarball shipped lib/d/src/base.o, config.h, 25 configured Makefiles and test/erl/_build. dist-hook now removes them. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
mergeable
Bot
added
the
build and general CI
slachiewicz
changed the title
slachiewicz
marked this pull request as ready for review
September 27, 2026 13:06
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
dist-hook now drops configured Makefiles (where a Makefile.in sits next to them), the root config.h, object files, rebar3's _build and rebar.lock, and empty directories. It does not narrow the whole-directory EXTRA_DIST entries; the hook covers every directory at once.
Verified: make dist in a configured tree with the 0.25.0 leftovers planted → 36 entries fewer, none of them tracked in git.