Repository navigation
THRIFT-6379: Link libboost_system only when Boost ships it - #3959
Open
slachiewicz wants to merge 1 commit into
Open
slachiewicz wants to merge 1 commit into
slachiewicz wants to merge 1 commit into
Conversation
mergeable
Bot
added
the
build and general CI
Client: cpp Boost.System is header-only since 1.69, and 1.89 stopped shipping the stub library, so the C++ tests and the cross-test client and server failed to link against current Boost. configure still links it where it exists, for Boost 1.56 to 1.68, and test/cpp now uses the same variable instead of -lboost_system. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
slachiewicz
force-pushed
the
THRIFT-6379
branch
from
September 27, 2026 12:01
d2401be to
9a02bb2
Compare
slachiewicz
changed the title
slachiewicz
marked this pull request as ready for review
September 27, 2026 16:27
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
configure links libboost_system.a only where Boost still ships it, and test/cpp uses that variable instead of a hard-coded -lboost_system.
Verified: configure against Homebrew Boost 1.92 leaves BOOST_SYSTEM_LDADD empty, and the lib/cpp tests and the test/cpp cross-test binaries link.