[SYSTEMDS-3681] Add stepGLM builtin function. - #2523
Open
Bruno-Ignaz wants to merge 19 commits into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2523 +/- ##
============================================
+ Coverage 71.38% 71.66% +0.27%
- Complexity 48753 49336 +583
============================================
Files 1571 1580 +9
Lines 188912 190517 +1605
Branches 37067 37364 +297
============================================
+ Hits 134857 136533 +1676
+ Misses 43593 43464 -129
- Partials 10462 10520 +58 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
christinadionysio
requested changes
Aug 11, 2026
christinadionysio
left a comment
Contributor
There was a problem hiding this comment.
Thank you for you PR, @Bruno-Ignaz!
I have a few minor things that should be improved before we can push your code into the upstream. It would be appreciated if you could have a look.
Author
|
Thanks @christinadionysio for the detailed feedback! |
Contributor
|
@Bruno-Ignaz could you please look at the failing github action? After this is fixed, I will merge it in. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
This is a homework pull-requests for the course AMLs at TUB.
This is also my first pull-request :)
I refactored
./scripts/algorithm/StepGLM.dmlinto a importable function.glm_fitwith adapter that uses the builtin solverm_gmlfrom./scripts/builtin/gml.dmlThe probit inverse link function is now approximated (AIC calculation):
Additionally:
./scripts/algorithms/TestBuiltinStepGLM.dmlperforms two checks for function output.Sources
[1]: Takeshi, Qualitative Response Models: A Survey (1981)