Repository navigation
Show the registry's trainingData resolution in make query - #3
Merged
Merged
Conversation
GET /records/{id} on the model record lists each trainingData entry
with the referenced dataset record's current status, looked up at
read time (sourcelume-registry#22). make query now asks for both
records and demo-atlas ends with the query, so the loop finishes on
the registry's answer instead of the Atlas UI alone. A fallback names
the direct publish call for the model record while the Python plugin
still rejects it client-side. README step 5 and the state table
describe the resolution and its read-time semantics.
Apache-ai: Yes
Generated-by: pi (claude-sonnet-5-5)
Reviewed-by: anierbeck
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sourcelume-registry#22 madeGET /records/{id}on a VALIDATEDTrainingProvenanceRecordresolve itstrainingDatareferences at read time: each entry carries the referenced dataset record's current status. That is the answer the demo exists for — the registry says "which datasets, in which state" instead of leaving the reader to resolve the references by hand.This PR shows it in the demo:
make querynow asks for both records; the model record's answer liststrainingDatawith the dataset'srecordStatus.make demo-atlasends with the query, so the loop finishes on the registry's answer.No record, schema or trainer change.
Testing
main(includes #22): published both records,make queryshows the model record withtrainingDatacarryingrecordStatus: VALIDATED.main.Apache-ai: Yes
Generated-by: pi (claude-sonnet-5-5)
Reviewed-by: anierbeck