Repository navigation
Fix CI workflows: approved docker/login-action SHA + retry flaky docker build - #229
Merged
Merged
Conversation
The ASF GitHub Actions policy only allows third-party actions pinned to an allowed commit SHA, so `docker/login-action@v1.10.0` is rejected. Pin it to `c94ce9fb468520275223c153574b00df6fe4bcc9`, the same revision the apache/skywalking workflows use. The inputs (registry/username/password) are unchanged. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
kezhenxu94
previously approved these changes
Jun 3, 2026
The Build job's `make docker` step boots buildkit by pulling moby/buildkit
from Docker Hub, which intermittently times out on shared runners
("Client.Timeout exceeded while awaiting headers"). Retry once, mirroring the
existing `make docker.push || make docker.push` pattern in publish-docker.yaml.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
wu-sheng
changed the title
wankai123
approved these changes
Jun 3, 2026
1 task
wu-sheng
added a commit
that referenced
this pull request
Jun 23, 2026
…ion SHA (#231) The pinned docker/login-action SHA c94ce9fb... (set in #229) is not on the ASF GitHub Actions allow-list, so the publish-docker workflow — which only runs on push to master, hence never exercised by a PR — fails at startup_failure on every master push. Switch to 650006c6...(v4.2.0), which is on the approved list and is the SHA apache/skywalking, skywalking-banyandb and skywalking-infra-e2e all use.
wu-sheng
added a commit
that referenced
this pull request
Oct 17, 2026
…237) * Fix publish-docker startup_failure: replace docker/login-action with docker login The ASF allow-list expired the docker/login-action v4.2.0 SHA pin, so the workflow failed at startup again after #236 merged (as before in #229 and #231). A plain `docker login --password-stdin` step does the same thing with no third-party pin to expire. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LUyq3m8dX1W9YceYrZB8yj * fix(deps): bump x/net, x/crypto and x/text for remaining advisories Upgrade golang.org/x/net to v0.60.0, golang.org/x/crypto to v0.57.0 and golang.org/x/text to v0.42.0 (x/sync, x/sys and x/term follow). This clears the advisories govulncheck still reports after #236, including five x/net HTTP/2 ones reachable from swctl's HTTP clients. The only remaining finding is GO-2026-5932 (x/crypto/openpgp is unmaintained, has no fix, and is not imported). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LUyq3m8dX1W9YceYrZB8yj --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two CI-workflow robustness fixes surfaced by the master CI run after #228.
1.
publish-docker.yaml— approveddocker/login-actionSHAThe ASF GitHub Actions policy only permits third-party actions pinned to an allowed commit SHA, so
docker/login-action@v1.10.0(a version tag) is rejected:Pinned to
c94ce9fb468520275223c153574b00df6fe4bcc9— the same revision the apache/skywalking workflows already use (so it's on the ASF allow-list). Inputs (registry/username/password) are unchanged, so it's a drop-in change. This was the only blocked action in the repo.2.
CI.yamlBuild job — retry the docker buildThe
Buildjob'smake dockerstep boots buildkit by pullingmoby/buildkit:buildx-stable-1from Docker Hub, which intermittently times out on shared runners:This flaked the Build job (and the Required gate) on the post-#228 master run, while all other jobs — including the new e2e suites — passed. Added a single retry (
make docker || make docker), mirroring the existingmake docker.push || make docker.pushpattern already used inpublish-docker.yaml.🤖 Generated with Claude Code