SAMZA-2319: [2/2] Simplify Container Allocation logic : Rename AbstractContainerAllocator to ContainerAllocator - #1169
Merged
Conversation
Contributor
Author
|
@rmatharu @vjagadish please have a look |
Sanil15
changed the title
rmatharu-zz
approved these changes
Sep 26, 2019
Contributor
There was a problem hiding this comment.
Could you take a look at the travis failure: https://travis-ci.org/apache/samza/builds/589636838?utm_source=github_status&utm_medium=notification
and then shipit
Sanil15
force-pushed
the
allocator-renaming
branch
from
September 27, 2019 21:23
439f0bc to
3ceeceb
Compare
prateekm
pushed a commit
to prateekm/samza
that referenced
this pull request
Oct 2, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: This PR just renames AbstractContainerAllocator to ContainerAllocator
Note: This is a stacked PR on: #1152
For the ease of reviewing, please review this PR from commit onwards:
439f0bc