Repository navigation
SAMZA-2302: Add equals, hashcode and toString to KV - #1138
Merged
Merged
Conversation
Contributor
Author
|
@cameronlee314 : please take a look. Thx! |
mynameborat
reviewed
Aug 14, 2019
cameronlee314
approved these changes
Aug 14, 2019
| return false; | ||
| } | ||
| KV<?, ?> otherKv = (KV<?, ?>) other; | ||
| return Objects.deepEquals(this.key, otherKv.key) |
Contributor
There was a problem hiding this comment.
Please add a comment about why we need deepEquals and that this implementation comes from Beam.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current KV class misses these primitive methods so that it can be used correctly in comparison, map or hash. Adding these methods to fix it.