Repository navigation
SAMZA-2298: Fix CoordinatorStreamStore creation for LocalApplicationRunner - #1136
Merged
rmatharu-zz merged 1 commit intoAug 30, 2019
Conversation
Contributor
Author
|
@shanthoosh @xinyuiscool - please review when you get a chance. Thanks. |
shanthoosh
reviewed
Aug 25, 2019
shanthoosh
left a comment
shanthoosh
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the changes.
dnishimura
commented
Aug 25, 2019
dnishimura
left a comment
dnishimura
left a comment
Contributor
Author
There was a problem hiding this comment.
Thanks for your review @shanthoosh . Please see my responses.
Contributor
Sure, Please create a follow-up ticket for it. |
shanthoosh
approved these changes
Aug 27, 2019
shanthoosh
left a comment
shanthoosh
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the clarifications.
LGTM.
Contributor
Author
Follow-up is tracked by SAMZA-2182 |
shekhars-li
pushed a commit
to shekhars-li/samza
that referenced
this pull request
May 28, 2021
RB=1784879 A= Updating comment RB=1784879 G=samza-reviewers A= Updating method name RB=1784879 G=samza-reviewers A= SAMZA-2298: Fix CoordinatorStreamStore creation for LocalApplicationRunner (apache#1136)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root Causes
For standalone, to prevent a double bootstrap of the coordinator stream in the coordinator stream metadata store from the
StreamProcessorand from theZkJobCoordinator, the initialization of the metadata store was moved up to theLocalApplicationRunner. However, during the refactor, the creation of the underlying coordinator stream was left out.The other root cause is that the assumption was made if a metadata store was not passed in to the
LocalApplicationRunner, by default it will create a coordinator stream metadata store. However, if a PassthroughJobCoordinator is used or if thejob.coordinator.systemis not defined, the underlying coordinator stream cannot be created. These need to be accounted for.Fix
Create the default coordinator stream metadata store only if using a
ZkJobCoordinatorand the coordinator system is defined, then create the underlying coordinator stream if a coordinator stream metadata store is used.Testing
Tested against beam and the beam-runner examples which use the
PassthroughJobCoordinator. Also tested against aZkJobCoordinatorjob.Follow on
The next phase of the metadata store abstraction SAMZA-2271 will clean up these work arounds.
@xinyuiscool @shanthoosh - please review when you get a chance.