Repository navigation
SAMZA-2296: Metadata streams not created in Standalone - #1132
Merged
shanthoosh merged 2 commits intoAug 9, 2019
Merged
shanthoosh merged 2 commits into
shanthoosh merged 2 commits into
Conversation
Contributor
Author
|
Please review, but hold off merges until I do some testing. |
Contributor
Author
|
Tested the fix on a backport to Samza 1.2 with a test standalone and test yarn job. I tested on both existing instances of the jobs and new instances of the jobs to trigger the creation of the new metadata streams. All verified to work. Please review. |
shanthoosh
approved these changes
Aug 9, 2019
shanthoosh
left a comment
shanthoosh
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the changes.
Fix it, then ship it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root cause
In standalone, the configs are being read from the JobModel, but in the standalone scenario, the config in the JobModel is not populated. The checkpoint and changelog system configurations were attempted to be read from the job model rather than the internally constructed configs.
Fix
Use the constructed config rather than the configs from JobModel