Repository navigation
Adding two additional params to DiagnosticsStreamMessage - #1126
Merged
rmatharu-zz merged 3 commits intoAug 7, 2019
Merged
Conversation
mynameborat
reviewed
Aug 5, 2019
mynameborat
left a comment
mynameborat
left a comment
Contributor
There was a problem hiding this comment.
Looks good overall. Minor comment and also please attach the jira to the PR.
| public DiagnosticsManager(String jobName, String jobId, Map<String, ContainerModel> containerModels, | ||
| Integer containerMemoryMb, Integer containerNumCores, Integer numStoresWithChangelog, String containerId, | ||
| String executionEnvContainerId, String taskClassVersion, String samzaVersion, String hostname, | ||
| Integer containerMemoryMb, Integer containerNumCores, Integer numStoresWithChangelog, Long maxHeapSizeBytes, Integer containerThreadPoolSize, |
Contributor
There was a problem hiding this comment.
nit: can we add the new parameters at the end?
Contributor
Author
There was a problem hiding this comment.
we could, i wanted to try and keep the sizing-related params together, container-id related together, and the remaining at the end.
cameronlee314
left a comment
cameronlee314
left a comment
Contributor
There was a problem hiding this comment.
Just a few minor things from me too
Contributor
Author
|
Addressed all comments. |
cameronlee314
approved these changes
Aug 6, 2019
Contributor
|
@rmatharu Please remember to include the JIRA ticket number in the commit message. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.