Skip to content

SAMZA-2288: Samza-sql - Make Udfs case-insensitive. #1122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
atoomula merged 1 commit into from
Aug 1, 2019
Merged

SAMZA-2288: Samza-sql - Make Udfs case-insensitive. #1122

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion samza-sql/src/main/java/org/apache/samza/sql/interfaces/UdfMetadata.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,8 @@ public class UdfMetadata {

public UdfMetadata(String name, String description, Method udfMethod, Config udfConfig, List<SamzaSqlFieldType> arguments,
SamzaSqlFieldType returnType, boolean disableArgCheck) {
this.name = name;
// Udfs are case insensitive
this.name = name.toUpperCase();
this.description = description;
this.udfMethod = udfMethod;
this.udfConfig = udfConfig;
Expand Down
7 changes: 6 additions & 1 deletion samza-sql/src/main/java/org/apache/samza/sql/planner/SamzaSqlUdfOperatorTable.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,12 @@ private SqlOperator getSqlOperator(SamzaSqlScalarFunctionImpl scalarFunction) {
@Override
public void lookupOperatorOverloads(SqlIdentifier opName, SqlFunctionCategory category, SqlSyntax syntax,
List<SqlOperator> operatorList) {
operatorTable.lookupOperatorOverloads(opName, category, syntax, operatorList);
SqlIdentifier upperCaseOpName = opName;
// Only udfs are case insensitive
if (category != null && category.equals(SqlFunctionCategory.USER_DEFINED_FUNCTION)) {
upperCaseOpName = new SqlIdentifier(opName.names.get(0).toUpperCase(), opName.getComponentParserPosition(0));
}
operatorTable.lookupOperatorOverloads(upperCaseOpName, category, syntax, operatorList);
}

@Override
Expand Down
2 changes: 1 addition & 1 deletion samza-test/src/test/java/org/apache/samza/test/samzasql/TestSamzaSqlEndToEnd.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -504,7 +504,7 @@ public void testEndToEndUdf() throws Exception {
TestAvroSystemFactory.messages.clear();
Map<String, String> staticConfigs = SamzaSqlTestConfig.fetchStaticConfigsWithFactories(configs, numMessages);
String sql1 = "Insert into testavro.outputTopic(id, long_value) "
+ "select id, MyTest(id) as long_value from testavro.SIMPLE1";
+ "select id, MYTest(id) as long_value from testavro.SIMPLE1";
List<String> sqlStmts = Collections.singletonList(sql1);
staticConfigs.put(SamzaSqlApplicationConfig.CFG_SQL_STMTS_JSON, JsonUtil.toJson(sqlStmts));
runApplication(new MapConfig(staticConfigs));
Expand Down