Skip to content

[SAMZA-2283] Samza Sql Diagnostics: use Nanosecond for logical operator processing time and query latency - #1117

Merged
atoomula merged 1 commit into
apache:masterfrom
shenodaguirguis:latency
Sep 4, 2019
Merged

[SAMZA-2283] Samza Sql Diagnostics: use Nanosecond for logical operator processing time and query latency#1117
atoomula merged 1 commit into
apache:masterfrom
shenodaguirguis:latency

Conversation

@shenodaguirguis

@shenodaguirguis shenodaguirguis commented Jul 26, 2019 •
edited
Loading

Copy link
Copy Markdown
Contributor
  1. Use nanoTime for SamzaSql specific latency metrics (i.e., logical operator processing time, and query latency)
  2. remove some unused imports

@shenodaguirguis
shenodaguirguis force-pushed the latency branch 2 times, most recently from fb884cd to d976075 Compare July 26, 2019 23:52
prateekm
prateekm requested changes Jul 27, 2019
View reviewed changes
Comment thread samza-core/src/main/java/org/apache/samza/system/inmemory/InMemoryManager.java Outdated
Comment thread samza-api/src/main/java/org/apache/samza/system/IncomingMessageEnvelope.java Outdated
Comment thread samza-api/src/main/java/org/apache/samza/system/IncomingMessageEnvelope.java Outdated
cameronlee314
cameronlee314 reviewed Jul 27, 2019
View reviewed changes
Comment thread samza-api/src/main/java/org/apache/samza/system/IncomingMessageEnvelope.java
Comment thread samza-api/src/main/java/org/apache/samza/system/IncomingMessageEnvelope.java Outdated
@shenodaguirguis
shenodaguirguis force-pushed the latency branch 2 times, most recently from c8f0180 to ea0d1ae Compare July 27, 2019 14:19
cameronlee314
cameronlee314 reviewed Jul 29, 2019
View reviewed changes
Comment thread samza-api/src/main/java/org/apache/samza/system/IncomingMessageEnvelope.java Outdated
Comment thread samza-api/src/main/java/org/apache/samza/system/IncomingMessageEnvelope.java Outdated
Comment thread samza-api/src/main/java/org/apache/samza/system/IncomingMessageEnvelope.java Outdated
Comment thread samza-api/src/main/java/org/apache/samza/system/IncomingMessageEnvelope.java
Comment thread samza-sql/src/main/java/org/apache/samza/sql/SamzaSqlInputTransformer.java Outdated
Comment thread samza-sql/src/main/java/org/apache/samza/sql/data/SamzaSqlRelMsgMetadata.java
Comment thread samza-sql/src/main/java/org/apache/samza/sql/translator/QueryTranslator.java Outdated
Comment thread samza-sql/src/test/java/org/apache/samza/sql/serializers/TestSamzaSqlRelMessageSerde.java
Comment thread samza-sql/src/test/java/org/apache/samza/sql/serializers/TestSamzaSqlRelRecordSerde.java
Comment thread samza-sql/src/test/java/org/apache/samza/sql/translator/TestProjectTranslator.java Outdated
@shenodaguirguis
shenodaguirguis force-pushed the latency branch 2 times, most recently from af467e9 to 12b0cd7 Compare August 30, 2019 19:02
@shenodaguirguis shenodaguirguis changed the title [SAMZA-2283] Samza Sql Diagnostics: make latency metrics changes backward compatible [SAMZA-2283] Samza Sql Diagnostics: use Microsecond for logical operator processing time and query latency Aug 30, 2019
prateekm
prateekm approved these changes Sep 3, 2019
View reviewed changes

@prateekm prateekm left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the update.

prateekm
prateekm reviewed Sep 3, 2019
View reviewed changes
Comment thread samza-sql/src/main/java/org/apache/samza/sql/translator/TranslatorConstants.java Outdated
prateekm
prateekm reviewed Sep 3, 2019
View reviewed changes
Comment thread samza-sql/src/main/java/org/apache/samza/sql/data/SamzaSqlRelMsgMetadata.java Outdated
@shenodaguirguis shenodaguirguis changed the title [SAMZA-2283] Samza Sql Diagnostics: use Microsecond for logical operator processing time and query latency [SAMZA-2283] Samza Sql Diagnostics: use Nanosecond for logical operator processing time and query latency Sep 3, 2019
@atoomula
atoomula merged commit ae8e857 into apache:master Sep 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@prateekm prateekm prateekm approved these changes
@cameronlee314 cameronlee314 cameronlee314 left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@shenodaguirguis @prateekm @cameronlee314 @atoomula