Skip to content

SAMZA-2279: [Scala cleanup] Convert JobConfig to Java - #1109

Merged
cameronlee314 merged 4 commits into
apache:masterfrom
cameronlee314:job_config_scala
Jul 31, 2019
Merged

cameronlee314 merged 4 commits into
apache:masterfrom
cameronlee314:job_config_scala

Conversation

@cameronlee314

Copy link
Copy Markdown
Contributor

No description provided.

@mynameborat mynameborat left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.
Thanks for the refactor!

Comment thread samza-core/src/main/java/org/apache/samza/context/JobContextImpl.java Outdated
Comment thread samza-core/src/main/java/org/apache/samza/runtime/LocalContainerRunner.java Outdated

@rmatharu-zz rmatharu-zz left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes.

@mynameborat mynameborat left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@cameronlee314
cameronlee314 merged commit f8092ef into apache:master Jul 31, 2019
@cameronlee314
cameronlee314 deleted the job_config_scala branch October 4, 2019 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants