[improve][client] Deduplicate in-progress lookup requests also for HttpLookupService - #25017
Merged
lhotari merged 3 commits intoDec 2, 2025
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #25017 +/- ##
=============================================
+ Coverage 38.55% 74.32% +35.76%
- Complexity 13323 34078 +20755
=============================================
Files 1863 1921 +58
Lines 146140 150337 +4197
Branches 16971 17461 +490
=============================================
+ Hits 56345 111738 +55393
+ Misses 82155 29687 -52468
- Partials 7640 8912 +1272
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
dao-jun
approved these changes
Dec 2, 2025
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Apr 23, 2026
… also for HttpLookupService (apache#25017) (cherry picked from commit b37b5b3) (cherry picked from commit 470b0e6)
nodece
pushed a commit
to ascentstream/pulsar
that referenced
this pull request
May 27, 2026
… also for HttpLookupService (apache#25017) (cherry picked from commit b37b5b3)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
There's currently de-duplication logic for in-progress lookup requests in the Pulsar client when the Pulsar binary protocol is used for the
serviceUrl. When using HTTP based lookup, the de-duplication is currently missing. This results in significant difference in behavior between the binary lookup and http based lookup.Modifications
Documentation
docdoc-requireddoc-not-neededdoc-complete