This repository was archived by the owner on Nov 17, 2023. It is now read-only.
Repository navigation
[v1.x]Backport #20626 from v1.9.x branch - #20644
Merged
Merged
Conversation
* Update LICENSE to include symlinks in include/dmlc licensed under non-ASF-2.0 licenses. * Update ca-certificates package on centos7 due to let's encrypt recent issue (see https://blog.devgenius.io/rhel-centos-7-fix-for-lets-encrypt-change-8af2de587fe4) * Update PDL package before installing PDL::CCS to prevent dependency issue. * Install latest ca-certificates package on aarch64 as well. * Change libtiff download URL to http to prevent let's encrypt CA chain issue. * update Dockerfile.build.ubuntu_cpu_jekyll * Use http to download libcurl to avoid let's encrypt intermediate CA cert expiration issue. * Lock down perl PDL version to specific version to prevent test failures. * No need to source rvm.sh in environment now that we are using a different container. * Update license_header.py tool to trigger error when two licenses are found. * Remove expired CA cert from ubuntu14.04 containers. * Revert "Change libtiff download URL to http to prevent let's encrypt CA chain issue." This reverts commit 3ae1192. * Revert "Use http to download libcurl to avoid let's encrypt intermediate CA cert expiration issue." This reverts commit 92432a6. * Back off retry count for windows builds to reduce cost. * Split test_hybrid_static_memory_switching() into 3 tests in order to isolate failures. * Skip mkldnn test, tracking at apache#20643. * Fix lint * Attempt to fix windows build parameters with MKLDNN builds - do not use debug builds when linking against MKLDNN. * Revert "Update ca-certificates package on centos7 due to let's encrypt recent issue (see https://blog.devgenius.io/rhel-centos-7-fix-for-lets-encrypt-change-8af2de587fe4)" This reverts commit 8b64859. * Add back change after revert. * Revert "Fix lint" This reverts commit 34b430c. * Revert "Skip mkldnn test, tracking at apache#20643." This reverts commit f45a6e3. * Revert "Split test_hybrid_static_memory_switching() into 3 tests in order to isolate failures." This reverts commit 23db9ba. * Revert changing windows build flags. Co-authored-by: Wei Chu <weichu@amazon.com>
…) to avoid bug triggered by let's encrypt expired ca cert.
josephevans
requested review from
aaronmarkham,
marcoabreu and
szha
as code owners
October 7, 2021 21:44
|
Hey @josephevans , Thanks for submitting the PR
CI supported jobs: [edge, unix-gpu, miscellaneous, centos-gpu, windows-cpu, unix-cpu, sanity, windows-gpu, clang, centos-cpu, website] Note: |
mseth10
added
pr-awaiting-testing
mseth10
added
pr-work-in-progress
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Port #20626 from v1.9.x branch into v1.x branch.
Also fix another issue with Let's Encrypt expired CA cert causing failures in openssl when downloading during builds.