Skip to content
This repository was archived by the owner on Nov 17, 2023. It is now read-only.

[v1.5.x] FP16 Support for C Predict API (#15245) - #16027

Closed
samskalicky wants to merge 1 commit into
apache:v1.5.xfrom
samskalicky:sskalic_fp16
Closed

samskalicky wants to merge 1 commit into
apache:v1.5.xfrom
samskalicky:sskalic_fp16

Conversation

@samskalicky

Copy link
Copy Markdown
Contributor
  • Upgrade archive utility and add back FC improvement

This reverts commit 6543488.

  • Change permissions for Ubuntu AR

  • Extract and cd into binutils dir

  • Allow AR path to be chosen by user

  • Add AR path to build

  • Fix AR paths

  • Revert AR flag in makefile

  • Build from source doc updated

  • Commit for C Predict API

  • Add FP16 predict support

  • Add Test Predictor fixes

  • Add test for predictor

  • Cleanup fixes

  • Fixes

  • Add support for forward pass only for gpu

  • Fix Reshape, move test to gpu

  • Add monitor callback for C Predict API

  • Add tests, default dtype and set_monitor_callback

  • Improve error

  • Fix c_str_array

Description

(Brief description on what this PR is about)

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

* Upgrade archive utility and add back FC improvement

This reverts commit 6543488.

* Change permissions for Ubuntu AR

* Extract and cd into binutils dir

* Allow AR path to be chosen by user

* Add AR path to build

* Fix AR paths

* Revert AR flag in makefile

* Build from source doc updated

* Commit for C Predict API

* Add FP16 predict support

* Add Test Predictor fixes

* Add test for predictor

* Cleanup fixes

* Fixes

* Add support for forward pass only for gpu

* Fix Reshape, move test to gpu

* Add monitor callback for C Predict API

* Add tests, default dtype and set_monitor_callback

* Improve error

* Fix c_str_array
@samskalicky

Copy link
Copy Markdown
Contributor Author

@TaoLv

@TaoLv TaoLv changed the title FP16 Support for C Predict API (#15245) [v1.5.x] FP16 Support for C Predict API (#15245) Aug 29, 2019
@TaoLv

TaoLv commented Aug 29, 2019

Copy link
Copy Markdown
Member

@samskalicky Could you please take a look at the CI failures?

@karan6181

Copy link
Copy Markdown
Contributor

@mxnet-label-bot add [FP16, C API, pr-awaiting-response]

@marcoabreu marcoabreu added C API FP16 pr-awaiting-response PR is reviewed and waiting for contributor to respond labels Aug 29, 2019
@samskalicky

Copy link
Copy Markdown
Contributor Author

This fix depends on #15118 which is a big feature, so im closing this PR for the 1.5.x branch. It will have to wait until 1.6.x

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

C API FP16 pr-awaiting-response PR is reviewed and waiting for contributor to respond

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants