feat: add Nimble to FileFormatType - #879
Open
zzhao0 wants to merge 1 commit into
Open
Conversation
Add `kNimble` to the `FileFormatType` enum along with its `ToString` and `FileFormatTypeFromString` mappings, so tables whose data files are written in the Nimble columnar format can be represented and round-tripped through manifest and REST JSON deserialization.
Member
|
IMHO, we cannot make this change until nimble has been formally accepted by the Iceberg spec. It would be good to start a discussion on dev@iceberg.apache.org to see what's the requirement to add a new file format. Vortex is doing this: https://docs.google.com/document/d/1g0EJDr3DkSmfAce8C94zA2JyWRj2SeNeAeiYOotnSww |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Working on integrating Nimble https://github.com/facebookincubator/nimble to iceberg. This requires extending the FileFormatType enum.
Add
kNimbleto theFileFormatTypeenum along with itsToStringandFileFormatTypeFromStringmappings, so tables whose data files are written in the Nimble columnar format can be represented and round-tripped through manifest and REST JSON deserialization.