[GEODE-10637] Skip the native image when the branch has no Dockerfile - #8064
Merged
Merged
Conversation
geode-native keeps its Dockerfiles in per-distro subdirectories, so docker/Dockerfile is absent and the build and push steps fail. Run them only when that file is present.
marinov-code
approved these changes
Sep 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
geode-native moved its Dockerfiles into per-distro subdirectories (docker/ubuntu-20.04/, docker/rhel-8/ and so on) and removed docker/Dockerfile in February 2021. It is absent on every current branch and release tag.
promote_rc.sh still does cd ${GEODE_NATIVE}/docker and docker build ., which fails with no Dockerfile in that directory. The retry chain docker build . || docker build . || docker build . fails as a whole, and under set -e this aborts the promotion at the native image build, before the Geode image is pushed.
Run the native image build and push only when docker/Dockerfile is present, and print a message when it is skipped.
For all changes, please confirm:
develop)?gradlew buildrun cleanly?