Skip to content

[fix](test) run search score TopN case in nonConcurrent group - #67402

Open
airborne12 wants to merge 1 commit into
apache:masterfrom
airborne12:fix-search-topn-nonconcurrent-master
Open

[fix](test) run search score TopN case in nonConcurrent group#67402
airborne12 wants to merge 1 commit into
apache:masterfrom
airborne12:fix-search-topn-nonconcurrent-master

Conversation

@airborne12

Copy link
Copy Markdown
Member

What problem does this PR solve?

Issue Number: N/A

Related PR: #67363 (same fix on branch-4.1), #67327 (backported the suite to branch-4.1), #65821 (introduced the suite on master)

Problem Summary:

test_search_score_topn_predicates (added on master by #65821) runs in the shared concurrent P0 group. On branch-4.1 it fails intermittently on its very first query, right after CREATE TABLE + INSERT + sync, with:

errCode = 2, detailMessage = [INTERNAL_ERROR]SearchExpr should not be executed without inverted index

This was observed on branch-4.1 CI (2 failures out of 4 runs) and fixed there by #67363, which moves the case into the nonConcurrent group. master carries the identical suite grouping ("p0"), so it is exposed to the same intermittent failure when the case races other P0 cases. This PR applies the same one-line fix to master to keep it out of the concurrent group.

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

Related PR: apache#67363 (same fix on branch-4.1); suite introduced by apache#65821 and backported via apache#67327.

test_search_score_topn_predicates runs in the shared concurrent P0 group and intermittently fails on its first query with "[INTERNAL_ERROR]SearchExpr should not be executed without inverted index". master carries the identical suite grouping as branch-4.1 (where it was observed flaky, 2/4 runs), so move it to the nonConcurrent group here too.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@hello-stephen

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@airborne12

Copy link
Copy Markdown
Member Author

run buildall

@airborne12

Copy link
Copy Markdown
Member Author

run nonConcurrent

@airborne12

Copy link
Copy Markdown
Member Author

run nonConcurrent

@airborne12

Copy link
Copy Markdown
Member Author

Status update on verification: the NonConcurrent pipeline has now failed three times in a row on this PR (builds 1036154, 1036404, 1036651) and in all three the run collapsed before reaching test_search_score_topn_predicates — the suite appears in neither the passed nor the failed list of any of them.

All three show the same environment signature rather than a test problem: FE IMAGE GENERATED FAIL (checkpoint failure) plus stop grace fail, with the run aborting after only 75-494 of the group's cases. The failures that are recorded are in unrelated suites — datatype_p0, ann_index_p0, table_stream_p0, row_binlog_p0, doc — none of which this one-line test-tag change touches.

I am not re-triggering further. What is verified so far: the suite passes locally with the tag applied, and the tag itself is the same grouping 41 other inverted_index_p0 cases already use. The final CI confirmation that it executes green inside the nonConcurrent group needs that pipeline to complete a run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants