[feature](function) Add ST_IsClosed function - #67350
Open
YanzhiJin5 wants to merge 1 commit into
Open
Conversation
YanzhiJin5
requested review from
924060929,
englefly,
morrySnow and
starocean999
as code owners
August 31, 2026 12:28
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
10 tasks
Author
|
run buildall |
Author
|
/review |
Contributor
TPC-H: Total hot run time: 16807 ms |
Contributor
TPC-DS: Total hot run time: 82164 ms |
Contributor
ClickBench: Total hot run time: 14.76 s |
Contributor
FE UT Coverage ReportIncrement line coverage |
Contributor
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: ref #48203
Related PR: apache/doris-website#4102
Problem Summary:
Add the
ST_IsClosedspatial scalar function.For a valid LineString, the function returns:
truewhen the first and last points are exactly equalfalsewhen the LineString is openNULLfor aNULLinputNULLfor a non-LineString or invalid encoded geometryThe implementation uses exact S2 point equality without introducing a tolerance.
This PR also adds Nereids registration and visitor support, FE and BE unit tests, and a self-asserting SQL regression suite.
Release note
Add the
ST_IsClosedspatial function.Check List (For Author)
Test
Regression test
Unit Test
VGeoFunctionsTest.*passedManual test
No need to test or manual test
Behavior changed:
Does this need documentation?