[fix](config) Mask sensitive FE configs in SHOW FRONTEND CONFIG via @ConfField(sensitive) - #67338
Open
starocean999 wants to merge 1 commit into
Open
[fix](config) Mask sensitive FE configs in SHOW FRONTEND CONFIG via @ConfField(sensitive)#67338starocean999 wants to merge 1 commit into
starocean999 wants to merge 1 commit into
Conversation
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
Author
|
/review |
Contributor
Author
|
run buildall |
Contributor
|
Codex automated review failed and did not complete. Error: Selected model is at capacity. Please try a different model. Please inspect the workflow logs and rerun the review after the underlying issue is resolved. |
Contributor
FE Regression Coverage ReportIncrement line coverage |
Contributor
TPC-H: Total hot run time: 17026 ms |
Contributor
TPC-DS: Total hot run time: 83165 ms |
Contributor
ClickBench: Total hot run time: 14.8 s |
starocean999
marked this pull request as ready for review
September 1, 2026 02:17
morrySnow
approved these changes
Sep 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
SHOW FRONTEND CONFIGexposes several password-related FE configs in plaintext, such asmysql_ssl_default_ca_certificate_password,key_store_password,tls_private_key_password,initial_root_password, andmysql_ssl_default_server_certificate_password. Any user with ADMINprivilege who can run
SHOW FRONTEND CONFIGcan read these secrets directly.This PR marks these config fields with
@ConfField(sensitive = true)inConfig.java, so the existingConfigBase.maskIfSensitivemechanism automatically masks their values with********inConfigBase.getConfigInfo()(used bySHOW FRONTEND CONFIG) andConfigBase.dump(). This is asingle, centrally maintained mechanism: any future sensitive config only needs the same annotation.
Only non-empty secrets are masked; empty values are left as-is to keep "unset" visible, and
non-sensitive configs are returned unchanged.
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)