branch-4.1: [fix](test) Stabilize Paimon external path regression case - #67085
Merged
yiguolei merged 1 commit intoAug 26, 2026
Merged
Conversation
Contributor
Author
|
run buildall |
Contributor
Author
|
/review |
Contributor
There was a problem hiding this comment.
Automated code review conclusion: no blocking issues found.
Opinion: approve. This is a comment-only review as required by the automated review instructions.
Critical checkpoints:
- Correctness: the patch replaces a probabilistic both-root assertion with a non-empty, all-files configured-set assertion that matches Paimon 1.4.2 writer-lifecycle semantics.
- Regression coverage: initial A/B placement, old-file retention, refreshed C/D placement, and Spark/Doris row parity remain enforced. The removed check covered upstream Paimon root distribution, not a Doris-owned cache or writer invariant.
- Compatibility, performance, and security/configuration: no regression or new exposure found in this assertion-only change.
- Convergence and deduplication: two full review rounds completed; the second normal and risk-focused reviews both returned NO_NEW_VALUABLE_FINDINGS. All earlier candidates were independently validated and dismissed with code evidence. No inline issue was accepted.
- Validation state: the live PR head/base still match the authoritative bundle, and no existing review or inline comment required deduplication. Static formatting, license, and dependency checks are green. TeamCity COMPILE is still running, and the focused external Paimon regression suite was not run in this review runner.
- User focus: no additional focus was provided; the complete PR was reviewed.
yiguolei
approved these changes
Aug 26, 2026
12 tasks
suxiaogang223
added a commit
to suxiaogang223/doris
that referenced
this pull request
Sep 3, 2026
### What problem does this PR solve? Issue Number: close apache#65086 Related PR: apache#65868, apache#66325, apache#67023, apache#67085 Problem Summary: Forward-port the final branch-4.1 Paimon write regression matrix to master, including append and primary-key modes, bucket routing, transactions, schema evolution, row-level DML, Variant V2, snapshot references, writer lifecycle, cache coherence, and stabilized external paths. Generated golden outputs are preserved byte-for-byte from branch-4.1. ### Release note None ### Check List (For Author) - Test: Regression test - Test cases and generated expected outputs were forward-ported; execution is deferred until the final integrated validation. - Behavior changed: No - Does this need documentation: No
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Problem summary
Paimon randomly initializes the round-robin position for each writer lifecycle. The regression case uses independent insert statements, so a valid finite run can select only one configured root and fail even though every file uses the configured path set.
Testing