Revert "[feature](lance) Add Rust-based Lance format reader for AI-native data (#62182) - #65303
Merged
Merged
Conversation
…tive dat… (apache#62182)" This reverts commit b613c37.
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
Author
|
run buildall |
Contributor
TPC-H: Total hot run time: 29944 ms |
Contributor
TPC-DS: Total hot run time: 180098 ms |
Contributor
ClickBench: Total hot run time: 25.07 s |
BiteTheDDDDt
approved these changes
Jul 7, 2026
github-actions
Bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
Contributor
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
FE UT Coverage ReportIncrement line coverage `` 🎉 |
Contributor
Author
|
run buildall |
Contributor
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
TPC-H: Total hot run time: 30071 ms |
Contributor
TPC-DS: Total hot run time: 180394 ms |
Contributor
ClickBench: Total hot run time: 25.26 s |
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
FE Regression Coverage ReportIncrement line coverage |
Contributor
Author
|
/review |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Automated review completed for PR #65303.
I did not find a substantiated inline issue in the 39-file GitHub PR patch. The revert removes the active Lance/Rust reader wiring from FE format parsing, BE scanner/schema dispatch, CMake/build hooks, Rust FFI sources, BE tests, and the Lance regression assets. I also checked the current merge ref; the only remaining Lance-related matches are thrift compatibility fields (FORMAT_LANCE, TLanceFileDesc, deprecated enable_rust_lance_reader) and the removed-session-variable compatibility entry in VariableMgr, not an active execution path.
Critical checkpoints:
- Goal and tests: the patch achieves the stated revert of the Lance reader feature and removes its dedicated tests/data. No new runtime behavior is introduced beyond rejecting
format = "lance"again. - Scope/focus: the change is narrowly scoped to removing the feature's active implementation and tests; no user focus was provided.
- Concurrency/lifecycle: no new concurrency, locks, long-lived state, or lifecycle ownership is introduced; deleted Rust reader resources and schema-reader paths are no longer reachable.
- Config/compatibility:
BUILD_RUST_READERSwiring is removed. The oldenable_rust_lance_readername remains only in the removed-session-variable compatibility list; thrift enum/descriptor remnants are compatibility surface and are not used by FE/BE dispatch. - Parallel paths: FE TVF format factory, BE scan reader dispatch, BE fetch-table-schema dispatch, build links, and test CMake paths were checked together.
- Testing/validation:
git diff --checkpassed on the real merge-base range and on the current merge-ref PR paths. Local build/tests were not run because this checkout lacks.worktree_initialized,thirdparty/installed, andthirdparty/installed/bin/protoc. PR rollup shows COMPILE, BE UT, FE UT, Cloud UT, P0/non-concurrent/cloud/vault regression, performance, and coverage success; GitHub macOS BE UT fails before Doris build because the job uses JDK 25 while Doris requires JDK 17, and External Regression is currently pending/inaccessible from this runner.
Subagent conclusions:
- optimizer-rewrite: no candidates; convergence round 1 returned
NO_NEW_VALUABLE_FINDINGS. - tests-session-config: no candidates; convergence round 1 returned
NO_NEW_VALUABLE_FINDINGS. - No candidate became an inline comment; no duplicates were merged.
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
FE Regression Coverage ReportIncrement line coverage |
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
FE Regression Coverage ReportIncrement line coverage |
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
FE Regression Coverage ReportIncrement line coverage |
Gabriel39
approved these changes
Jul 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
This reverts commit b613c37. #62182
will be later support lance catalog full.
Problem Summary:
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)