[fix](workload policy)Remove set session variable workload policy action - #64856
Conversation
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
|
Please also remove the document from master and 4.x |
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
|
run buildall |
TPC-H: Total hot run time: 29248 ms |
TPC-DS: Total hot run time: 171186 ms |
ClickBench: Total hot run time: 25.18 s |
FE UT Coverage ReportIncrement line coverage |
FE Regression Coverage ReportIncrement line coverage |
|
add related PR |
|
PR approved by at least one committer and no changes requested. |
|
/review |
### What problem does this PR solve?
Issue Number: None
Related PR: None
Problem Summary: The workload policy set_session_variable action has problematic behavior and is being removed. This change removes its parser special case, runtime action implementation, and action type registration, then updates workload policy tests so new policies reject set_session_variable as an invalid action. Existing BE-side workload policy actions remain unchanged.
### Release note
The set_session_variable workload policy action is no longer supported.
### Check List (For Author)
- Test:
- Unit Test: ./run-fe-ut.sh --run org.apache.doris.resource.workloadschedpolicy.WorkloadSchedPolicyMgrTest (passed; rerun with elevated permissions after Mockito inline attach failed under sandbox)
- Checkstyle: mvn checkstyle:check -pl fe-core,fe-sql-parser (passed)
- Regression test: ./run-regression-test.sh --run -d workload_manager_p0 -s test_workload_sched_policy (attempted, failed because local 127.0.0.1:9030 Doris cluster was not running)
- Behavior changed: Yes. set_session_variable workload policy action is rejected.
- Does this need documentation: No
4fc1b5e to
c5eaf8c
Compare
|
run buildall |
TPC-H: Total hot run time: 17453 ms |
TPC-DS: Total hot run time: 83295 ms |
ClickBench: Total hot run time: 14.56 s |
304015a
|
run buildall |
TPC-H: Total hot run time: 17544 ms |
TPC-DS: Total hot run time: 83200 ms |
ClickBench: Total hot run time: 14.72 s |
FE UT Coverage ReportIncrement line coverage |
FE Regression Coverage ReportIncrement line coverage |
…ion (#64856) ### What problem does this PR solve? Related PR: #28443 Problem Summary: The workload policy set_session_variable action has problematic behavior and is being removed. This change removes its parser special case, runtime action implementation, and action type registration, then updates workload policy tests so new policies reject set_session_variable as an invalid action. Existing BE-side workload policy actions remain unchanged. ### Release note The set_session_variable workload policy action is no longer supported.
What problem does this PR solve?
Related PR: #28443
Problem Summary: The workload policy set_session_variable action has problematic behavior and is being removed. This change removes its
parser special case, runtime action implementation, and action type registration, then updates workload policy tests so new policies reject set_session_variable as an invalid action. Existing BE-side workload policy actions remain unchanged.
Release note
The set_session_variable workload policy action is no longer supported.
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)