Conversation
bobhan1
requested review from
CalvinKirs,
dataroaring,
gavinchou,
morningman,
w41ter and
yiguolei
as code owners
April 3, 2026 04:03
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Add a new immutable table property 'float_type_default_use_plain_encoding' that controls whether FLOAT/DOUBLE column types use PLAIN encoding instead of the default BIT_SHUFFLE encoding. - Property is boolean, defaults to false - Cannot be modified after table creation (ALTER TABLE throws error) - Displayed in SHOW CREATE TABLE output - Orthogonal to storage format (V3 does not auto-enable this) - Propagated through both non-cloud (thrift) and cloud (protobuf) paths - BE encoding hook transforms BIT_SHUFFLE -> PLAIN for float/double types when enabled Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
bobhan1
force-pushed
the
float-use-plain-encoding
branch
from
April 3, 2026 04:09
5f0eb61 to
fe5ebb6
Compare
Contributor
Author
|
run buildall |
Contributor
Cloud UT Coverage ReportIncrement line coverage Increment coverage report
|
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
TPC-H: Total hot run time: 29014 ms |
TPC-DS: Total hot run time: 178692 ms |
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
…when true Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
bobhan1
force-pushed
the
float-use-plain-encoding
branch
from
April 3, 2026 09:10
2c9dc6e to
dfcec16
Compare
Contributor
Author
|
run buildall |
Cloud UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
TPC-H: Total hot run time: 28957 ms |
TPC-DS: Total hot run time: 178538 ms |
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
Author
|
use #62649 instead |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Problem Summary:
FLOAT/DOUBLE types always default to BIT_SHUFFLE encoding. Users need a table property to control whether PLAIN encoding is used instead, similar to the existing
integer_type_default_use_plain_encodingfor integer types.This PR adds a new immutable table property
float_type_default_use_plain_encoding(boolean, defaultfalse):true, FLOAT/DOUBLE columns use PLAIN encoding instead of BIT_SHUFFLEUsage:
Release note
Add a new table property float_type_default_use_plain_encoding to control whether FLOAT/DOUBLE types use PLAIN encoding instead of the default BIT_SHUFFLE encoding.
Check List (For Author)
Check List (For Reviewer who merge this PR)