[improve](float) improve float and double to string - #54760
Merged
Conversation
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 33800 ms |
jacktengg
force-pushed
the
float-to-string
branch
from
August 14, 2025 08:15
fa7eb0e to
46ffbe0
Compare
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 33957 ms |
TPC-DS: Total hot run time: 184811 ms |
Contributor
Possible file(s) that should be tracked in LFS detected: 🚨The following file(s) exceeds the file size limit:
Consider using |
github-actions
Bot
added
the
lfs-detected!
Mryange
reviewed
Aug 15, 2025
| static std::string to_string(const void* src) { | ||
| char buf[1024] = {'\0'}; | ||
| int length = to_buffer(*reinterpret_cast<const CppType*>(src), MAX_FLOAT_STR_LENGTH, buf); | ||
| int length = fast_to_buffer(*reinterpret_cast<const CppType*>(src), buf); |
Contributor
There was a problem hiding this comment.
为什么是调用这个fast_to_buffer，而不是调用CastToString
Mryange
reviewed
Aug 15, 2025
| char buf[MAX_FLOAT_STR_LENGTH + 2]; | ||
| int len = to_buffer(data, MAX_FLOAT_STR_LENGTH + 2, buf); | ||
| char buf[MAX_DOUBLE_STR_LENGTH + 2]; | ||
| int len = fast_to_buffer(data, buf); |
Contributor
There was a problem hiding this comment.
这里也是，可以直接调用CastToString，这样对外的接口就比较统一了。
jacktengg
force-pushed
the
float-to-string
branch
from
August 15, 2025 13:46
7b4e1d4 to
ef7512a
Compare
Contributor
Author
|
run buildall |
Contributor
Possible file(s) that should be tracked in LFS detected: 🚨The following file(s) exceeds the file size limit:
Consider using |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
jacktengg
force-pushed
the
float-to-string
branch
from
August 15, 2025 16:35
ef7512a to
7f05805
Compare
Contributor
Possible file(s) that should be tracked in LFS detected: 🚨The following file(s) exceeds the file size limit:
Consider using |
jacktengg
force-pushed
the
float-to-string
branch
from
August 15, 2025 17:25
7f05805 to
4e8a078
Compare
Contributor
Author
|
run buildall |
Contributor
Possible file(s) that should be tracked in LFS detected: 🚨The following file(s) exceeds the file size limit:
Consider using |
jacktengg
force-pushed
the
float-to-string
branch
from
August 15, 2025 17:28
4e8a078 to
1d2f9d5
Compare
Contributor
Author
|
run buildall |
Contributor
Possible file(s) that should be tracked in LFS detected: 🚨The following file(s) exceeds the file size limit:
Consider using |
jacktengg
force-pushed
the
float-to-string
branch
from
August 15, 2025 18:02
1d2f9d5 to
fcb1429
Compare
Contributor
Possible file(s) that should be tracked in LFS detected: 🚨The following file(s) exceeds the file size limit:
Consider using |
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 33945 ms |
TPC-DS: Total hot run time: 185269 ms |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
jacktengg
force-pushed
the
float-to-string
branch
from
August 25, 2025 02:22
2027f82 to
10dc0ca
Compare
Contributor
Author
|
run buildall |
Contributor
Possible file(s) that should be tracked in LFS detected: 🚨The following file(s) exceeds the file size limit:
Consider using |
jacktengg
force-pushed
the
float-to-string
branch
from
August 25, 2025 02:41
10dc0ca to
cad0601
Compare
Contributor
Author
|
run buildall |
Contributor
Possible file(s) that should be tracked in LFS detected: 🚨The following file(s) exceeds the file size limit:
Consider using |
TPC-H: Total hot run time: 33926 ms |
TPC-DS: Total hot run time: 185119 ms |
ClickBench: Total hot run time: 32.79 s |
Contributor
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
Author
|
run external |
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
yiguolei
approved these changes
Aug 25, 2025
github-actions
Bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
Mryange
approved these changes
Aug 25, 2025
16 tasks
csun5285
added a commit
that referenced
this pull request
Jul 15, 2026
Zone-map DOUBLE/FLOAT min/max were formatted with digits10+1 (16g/7g, #54760), which fails to round-trip finite extremes — ±DBL_MAX overflows to ±inf on readback, ±FLT_MAX loses precision — corrupting the zone map.
wyxxxcat
pushed a commit
to wyxxxcat/doris
that referenced
this pull request
Aug 17, 2026
Zone-map DOUBLE/FLOAT min/max were formatted with digits10+1 (16g/7g, apache#54760), which fails to round-trip finite extremes — ±DBL_MAX overflows to ±inf on readback, ±FLT_MAX loses precision — corrupting the zone map.
csun5285
added a commit
to csun5285/doris
that referenced
this pull request
Aug 31, 2026
### What problem does this PR solve? Related PR: apache#54760, apache#61277, apache#65302 Problem Summary: A zone map bound that fails to parse is unknown, not null -- older versions wrote DOUBLE bounds with digits10+1 precision, so DBL_MAX reads back as infinity and is rejected. Mark such a zone map pass_all so it prunes nothing, instead of failing every scan that loads it. ### Release note None Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01TPTGDEAgu5sQVYYvfvyTJz
csun5285
added a commit
to csun5285/doris
that referenced
this pull request
Aug 31, 2026
### What problem does this PR solve? Related PR: apache#54760, apache#61277, apache#65302 Problem Summary: A zone map bound that fails to parse is unknown, not null -- older versions wrote DOUBLE bounds with digits10+1 precision, so DBL_MAX reads back as infinity and is rejected. Mark such a zone map pass_all so it prunes nothing, instead of failing every scan that loads it. Pushed-down MIN/MAX falls back to a normal scan when a segment zone map turns out to be invalid. ### Release note None Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01TPTGDEAgu5sQVYYvfvyTJz
csun5285
added a commit
to csun5285/doris
that referenced
this pull request
Aug 31, 2026
### What problem does this PR solve? Related PR: apache#54760, apache#61277, apache#65302 Problem Summary: A zone map bound that fails to parse is unknown, not null -- older versions wrote DOUBLE bounds with digits10+1 precision, so DBL_MAX reads back as infinity and is rejected. Mark such a zone map pass_all so it prunes nothing, instead of failing every scan that loads it. Pushed-down MIN/MAX falls back to a normal scan when a segment zone map turns out to be invalid. ### Release note None Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01TPTGDEAgu5sQVYYvfvyTJz
csun5285
added a commit
to csun5285/doris
that referenced
this pull request
Sep 1, 2026
### What problem does this PR solve? Related PR: apache#54760, apache#61277, apache#65302 Problem Summary: A zone map bound that fails to parse is unknown, not null -- older versions wrote DOUBLE bounds with digits10+1 precision, so DBL_MAX reads back as infinity and is rejected. Mark such a zone map pass_all so it prunes nothing, instead of failing every scan that loads it. Pushed-down MIN/MAX falls back to a normal scan when a segment zone map turns out to be invalid. ### Release note None Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01TPTGDEAgu5sQVYYvfvyTJz
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)