[doc](catalog) Add read capabilities to catalog matrices - #4124
Open
OIiveirra wants to merge 2 commits into
Open
[doc](catalog) Add read capabilities to catalog matrices#4124OIiveirra wants to merge 2 commits into
OIiveirra wants to merge 2 commits into
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The zh-CN Iceberg matrix introduces a new “Metadata Table” group label that remains in English and should be localized for consistency with nearby Chinese labels.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
This PR updates the Apache Doris Lakehouse documentation (dev/current) to extend the Iceberg and Paimon catalog capability matrices with explicit read capabilities for views, branches/tags, and Iceberg metadata tables, keeping EN and zh-CN pages structurally aligned.
Changes:
- Add
READ_VIEWcapability rows under the View capability group for both Iceberg and Paimon matrices. - Add
BRANCH_READandTAG_READcapability rows under the Branch / Tag capability group for both matrices. - Add
READ_METADATA_TABLEunder a new “Metadata Table” capability group for the Iceberg matrix.
Checkpoint Assessment
- Goal & satisfaction: The diffs implement the stated goal by adding the requested capability rows and adjusting
rowSpanvalues accordingly. - Scope & focus: Changes are narrowly scoped to the capability matrices without unrelated rewrites.
- Information architecture & sync: Current/dev docs are updated for both English and Chinese counterparts as described; however, one newly added label in zh-CN remains untranslated (see comment).
- Links/routing/sidebars: No paths/slugs/sidebar items changed in this PR, so no navigation updates are applicable.
- Docusaurus/MDX correctness: The table edits appear structurally consistent (row counts match updated
rowSpanvalues in reviewed hunks). - Validation coverage: No automated tests are applicable for doc-only MDX changes; review is based on structural inspection of the edited table regions.
- Other usability/accessibility/maintainability: Minor localization consistency issue in the zh-CN Iceberg matrix for the newly added “Metadata Table” group label.
File summaries
| File | Description |
|---|---|
docs/lakehouse/best-practices/doris-paimon-capability-matrix.mdx |
Adds READ_VIEW, BRANCH_READ, and TAG_READ rows and updates related rowSpan values. |
docs/lakehouse/best-practices/doris-iceberg-capability-matrix.mdx |
Adds READ_VIEW, BRANCH_READ, TAG_READ, and READ_METADATA_TABLE rows and updates related rowSpan values. |
i18n/zh-CN/docusaurus-plugin-content-docs/current/lakehouse/best-practices/doris-paimon-capability-matrix.mdx |
Mirrors the English Paimon matrix additions and rowSpan updates for zh-CN. |
i18n/zh-CN/docusaurus-plugin-content-docs/current/lakehouse/best-practices/doris-iceberg-capability-matrix.mdx |
Mirrors the English Iceberg matrix additions; one new group label needs localization for consistency. |
Review details
- Files reviewed: 4/4 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| <td align="center">✅</td> | ||
| </tr> | ||
| <tr> | ||
| <td>Metadata Table</td> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Versions
Languages
Docs Checklist
Summary
table@branch(...)andtable@tag(...)queriesThis is a follow-up to #4116 and updates the current/dev documentation only.
Validation
git diff --check origin/masterrowSpanmatches its capability group