chore: remove the dbt plugin and alpine-dbt docker image - #9084
Merged
Merged
Conversation
Remove the deprecated dbt plugin from the backend, its alpine-dbt Docker image, the config-ui example entry, and the dbt-mysql / dbt-postgres Python dependencies. Update the plugin registration test lists (table_info, schema_e2e, server_startup) accordingly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes the deprecated
dbtplugin from the backend, itsalpine-dbtDocker image, the correspondingconfig-uiexample entry, and thedbt-mysql/dbt-postgresPython dependencies. Updates the plugin registration test lists (table_info_test.go,migration_schema_test.go,server_startup_test.go) accordingly.Closes #8970.
Background
Per the issue, the
dbtplugin architecture relies on passing external user-supplied configurations to external CLI tools (gitanddbt), exposing the server to SSRF and CLI argument manipulation. Rather than maintaining complex input-filtering rules for this changing command-line surface, the plugin is being deprecated and removed from the codebase.Scope
backend/plugins/dbt/(9 files: entry point, impl, api/swagger, tasks/convertor, tasks/git, tasks/options, tasks/options_test, tasks/task_data, README)devops/docker/alpine-dbt/(Dockerfile + README)example/dbt.tsand removed thedbtentry fromexample/index.tsdbt-mysqlanddbt-postgresfrombackend/python/requirements.txtdbtimports and registrations fromtable_info_test.go,migration_schema_test.go, andserver_startup_test.goVerification
go vetpasses for the edited packages (only a pre-existing, unrelatedlibgit2system-dependency error remains)tsc --noEmitpasses forconfig-uirgfor all dbt plugin symbols (plugins/dbt,dbt/impl,alpine-dbt,dbt-mysql,dbt-postgres,DbtOptions,DbtTaskData,DbtConverter,impl.Dbt,dbt.Dbt) returns no matchesChecklist
dbtpackagebackend/plugins/directories