[nseekhao]

Which issue does this PR close?

Closes #6866 .

Rationale for this change

Explained in issue.

What changes are included in this PR?

• Parse DF join filter into Substrait's post_join_filter in producer
• Parse post_join_filter into join filter in consumer
• Test cases:
  • non-empty join expression, non-empty filter
  • empty join expression, non-empty filter
  • query with exists clause

Are these changes tested?

Yes.

Please note that if a test case includes subquery aliases, the results will not be correct due to issue #6867 .

Are there any user-facing changes?

No

[nseekhao]

Does anyone know what's the difference between the tests/roundtrip_logical_plan.rs file and the tests/cases/roundtrip_logical_plan.rs file?

[andygrove]

@waynexia fyi

[waynexia]

Looking great, thanks 👍

[waynexia]

Does anyone know what's the difference between the tests/roundtrip_logical_plan.rs file and the tests/cases/roundtrip_logical_plan.rs file?

I just realized we have two different case files 🤣 It looks like this is a mistake from #6604. I'll reorganize those test cases later when I split our consumer/producer implementation into functionality-grouped style. I believe there are many duplications...

[alamb]

I just realized we have two different case files 🤣 It looks like this is a mistake from #6604. I'll reorganize those test cases later when I split our consumer/producer implementation into functionality-grouped style. I believe there are many duplications...

I took a quick look at it looks to me like the tests are entirely duplicated. Proposed removing them here: #6894