bench: add simplify_function_over_case benchmark - #24489
Merged
kosiew merged 2 commits intoSep 1, 2026
Merged
Conversation
radmirnovii
marked this pull request as ready for review
August 19, 2026 12:53
radmirnovii
force-pushed
the
bench-simplify-function-over-case
branch
from
August 19, 2026 13:45
90b19cf to
d929db0
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #24489 +/- ##
==========================================
- Coverage 81.39% 81.39% -0.01%
==========================================
Files 1118 1118
Lines 398692 398692
Branches 398692 398692
==========================================
- Hits 324525 324518 -7
- Misses 55198 55205 +7
Partials 18969 18969 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
radmirnovii
force-pushed
the
bench-simplify-function-over-case
branch
from
August 24, 2026 13:23
d929db0 to
c83c2d0
Compare
kosiew
approved these changes
Aug 28, 2026
kosiew
left a comment
Contributor
There was a problem hiding this comment.
Thanks for adding this benchmark ahead of the optimizer change. The setup looks useful for comparing the current behavior against the follow-up rule, and I don't see anything blocking here.
I left a couple of optional suggestions around making the evaluation benchmark a bit easier to interpret and compare.
Contributor
Author
|
Thanks for the review. |
Contributor
|
🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
Spin-off of #24477: have a benchmark for
f(CASE-of-literals)simplificationand evaluation available before the PR with the rule, to compare against
main.What changes are included in this PR?
A new
simplify_function_over_caseCriterion benchmark fordatafusion-optimizer:simplify/{2,8,32}(plan-time simplifier cost over Nliteral branches) and
evaluate_8192_rows(per-batch evaluation after thestandard simplification pipeline). Measurement coverage only; no behavior change.
Are these changes tested?
Yes: the benchmark compiles and runs on
main(
cargo bench -p datafusion-optimizer --bench simplify_function_over_case);fmt and clippy pass.
Are there any user-facing changes?
No.