Repository navigation
Implement the POSITION function #8969
Description
Is your feature request related to a problem or challenge?
The idea is to support the position function from postgres:
https://www.postgresql.org/docs/9.1/functions-string.html
position(substring in string) For example
postgres=# select position('world' in 'Helloworld');
position
----------
6
(1 row)Describe the solution you'd like
As @zy-kkk points out on #8862 (comment) postgres has special syntax
To support the syntax position('world' in 'Helloworld') = 6 we probably need to do it in at https://github.com/sqlparser-rs/sqlparser-rs and add support for this syntax , which may be like adding the overlay function in apache/datafusion-sqlparser-rs#594.
Then we can change the datafusion planner to recognize that special syntax and call the instr function in #8862
Describe alternatives you've considered
No response
Additional context
This came up while implementing #8862
Activity
alamb commentedon Jan 23, 2024
I think this is a good first issue, though it will require updating sqlparser-rs and then waiting for that to be released and making a change in datafusion
Lordworms commentedon Jan 23, 2024
I would like to try that
feat: issue apache#8969 adding position function
Lordworms commentedon Jan 24, 2024
Hello, @alamb I have created a PR plz review it if you have time. Additionally, I have some other problems:
I would appreciate so much for your answer
alamb commentedon Jan 25, 2024
Thank you @Lordworms - I have it on my
From my perspective there is no particular deadline for any issue.
Instead, if someone is working on an issue but wasn't able to finish it before someone else needs / wants to work on the same thing, that other person can simply make a PR.
I think most contributors are polite and check with the person who first signaled interest before working on something, but just because someone else might be working on something doesn't prevent anyone else from doing so
I think making a draft PR to run the full suite of tests so you know which ones may need to run locally is a very reasonable strategy
I don't have a good answer for this -- Rust development environments in general do require significant resources
Lordworms commentedon Jan 25, 2024
Thank you, got it!
feat: issue apache#8969 adding position function
feat: issue apache#8969 adding position function
feat: issue apache#8969 adding position function
feat: issue apache#8969 adding position function
feat: issue apache#8969 adding position function
feat: issue apache#8969 adding position function
feat: issue apache#8969 adding position function
feat: issue apache#8969 adding position function
feat: issue #8969 adding position function (#8988)
SteveLauC commentedon Feb 29, 2024
Seems that we should close this issue as it was completed in #8988
alamb commentedon Feb 29, 2024
Thank you @SteveLauC -- good call