Skip to content

Port tests in repartition.rs to sqllogictest #8212

Description

@alamb

Is your feature request related to a problem or challenge?

Part of #6195. We are trying to

  1. keep the DataFusion code base clean and easy to contribute to and modify
  2. Understand what features are covered and what are not

Part of doing so is having a single location for most test coverage so new tests can be added easily and people can follow the existing patterns easily

Describe the solution you'd like

Port the tests in https://github.com/apache/arrow-datafusion/blob/main/datafusion/core/tests/sql/repartition.rs to
repartition.slt in https://github.com/apache/arrow-datafusion/tree/main/datafusion/sqllogictest/test_files

Note you can create catalogs and schema via SQL now

Catalogs: https://arrow.apache.org/datafusion/user-guide/sql/ddl.html#create-database
Schema: https://arrow.apache.org/datafusion/user-guide/sql/ddl.html#create-schema

Notes:

  1. Instructions for running sqllogitest are here: https://github.com/apache/arrow-datafusion/tree/main/datafusion/sqllogictest

Describe alternatives you've considered

No response

Additional context

I think these are good first issues as they teach the contributor about the DataFusion codebase and tests, as well as see the end user apis in practice.

No response

Activity

  1. alamb commented on Jan 21, 2024

    @alamb
    ContributorAuthor

    The remaining tests in this file can't be ported to sqllogictest so I think this one is done

  2. simicd commented on Jan 21, 2024

    @simicd
    Contributor

    Hi @alamb, saw your comment only now after pushing my PR 😄 Very curious to hear your thoughts on whether it mimics the old test sufficiently closely

  3. alamb commented on Jan 21, 2024

    @alamb
    ContributorAuthor

    Oops -- sorry @simicd -- looking now

  4. reopened this on Jan 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions