Skip to content

Port tests in explain_analyze.rs to sqllogictest #8200

Description

@alamb


Is your feature request related to a problem or challenge?

Part of #6195. We are trying to

  1. keep the DataFusion code base clean and easy to contribute to and modify
  2. Understand what features are covered and what are not

Part of doing so is having a single location for most test coverage so new tests can be added easily and people can follow the existing patterns easily

Describe the solution you'd like

Port the tests in https://github.com/apache/arrow-datafusion/blob/main/datafusion/core/tests/sql/explain_analyze.rs to
explain_analyze.slt in https://github.com/apache/arrow-datafusion/tree/main/datafusion/sqllogictest/test_files

Note you can create catalogs and schema via SQL now

Catalogs: https://arrow.apache.org/datafusion/user-guide/sql/ddl.html#create-database
Schema: https://arrow.apache.org/datafusion/user-guide/sql/ddl.html#create-schema

Notes:

  1. Instructions for running sqllogitest are here: https://github.com/apache/arrow-datafusion/tree/main/datafusion/sqllogictest

Describe alternatives you've considered

No response

Additional context

I think these are good first issues as they teach the contributor about the DataFusion codebase and tests, as well as see the end user apis in practice.

Activity

  1. alamb commented on Nov 15, 2023

    @alamb
    ContributorAuthor

    I am not sure if this test is easy to port or not (it may required normalization of the output that is not possible in sqllogictests)

  2. Tangruilin commented on Jan 25, 2024

    @Tangruilin
    Contributor

    Maybe I can help with this.

    But I am not sure if the test is easy to port, maybe i will need some help @alamb

  3. alamb commented on Jan 25, 2024

    @alamb
    ContributorAuthor

    Thanks @Tangruilin -- I took a look at the test again, and I think it is not easy / possible to port this test, so lets close the ticket.

    Sorry for the noise

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions