Skip to content

Logical Expr serde should be stack safe #5693

Description

@thinkharderdev

Is your feature request related to a problem or challenge?

Noticed while working on #5691 I was getting stack overflows while running tests (well actually a segfault but after some investigation I think it was just a quirk of my ARM mac and really the underlying issue was a stack overflow). I was able to run the tests by compiling them in release mode but the current recursive expression parsing/translation is not stack safe and will likely eventually cause issues.

Otherwise deeply nested expressions can cause a system crash.

Describe the solution you'd like

Avoid recursion in datafusion_proto::logical_plan::from_proto::parse_expr

Describe alternatives you've considered

Leave it as is and document as a known limitation

Additional context

No response

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions