Fixed stage name parsing for snowflake - #2265
Merged
iffyio merged 3 commits intoMar 13, 2026
Merged
Conversation
added 2 commits
March 4, 2026 14:32
iffyio
reviewed
Mar 9, 2026
| fn test_snowflake_stage_name_with_special_chars() { | ||
| // Stage path with '=' (Hive-style partitioning) | ||
| let sql = "SELECT * FROM @stage/day=18/23.parquet"; | ||
| let stmt = snowflake().parse_sql_statements(sql).unwrap(); |
Contributor
There was a problem hiding this comment.
can we use the one_statement_parse_to (or verified_stmt if that works) for the tests?
Author
|
@iffyio Updated. Thank you |
iffyio
approved these changes
Mar 13, 2026
sabir-akhadov-localstack
added a commit
to localstack/datafusion-sqlparser-rs
that referenced
this pull request
Aug 24, 2026
… ROLES (apache#2265) * Task LAV-1788: CREATE/ALTER ROLE COMMENT round-trips through SHOW ROLES Parse Snowflake CREATE ROLE ... COMMENT = '...', thread the comment through the create_role UDF, and add the is_from_organization_user_group column (11th) to SHOW ROLES plus a SHOW TERSE ROLES projection. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * Task LAV-1788: assert full 11-column SHOW ROLES in create-role-comment test The new test stripped is_from_organization_user_group with a stale 'emulator omits' comment, papering over the very column this task adds (the emulator does emit it — see test_show_roles). Drop the strip and assert the column (constant 'N') across the round-trip instead. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * Task LAV-1788: waive test_rbac re-record; verified is_inherited drift * Task LAV-1788: assert 11-column SHOW ROLES in rename/unset/limit tests Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * Task LAV-1788: respect INITIALIZE=ON_SCHEDULE in dynamic-table scheduler The refresh scheduler treated any never-refreshed ACTIVE dynamic table as immediately due, refreshing ON_SCHEDULE tables on the next poll tick despite their create-time contract (created empty until the first scheduled refresh). test_dynamic_tables_never_refreshed raced this poll and flaked under parallel load. Anchor a never-refreshed ON_SCHEDULE table's first due time at created_at + TARGET_LAG; other never-refreshed tables stay due immediately. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed special characters in stage name parsing for snowflake
Example queries:
Spec: https://docs.snowflake.com/en/user-guide/querying-stage