Fix credentials parsing for redshift - #2262
Merged
Merged
Conversation
iffyio
approved these changes
Mar 4, 2026
sabir-akhadov-localstack
added a commit
to localstack/datafusion-sqlparser-rs
that referenced
this pull request
Aug 24, 2026
…h argument types (apache#2262) * Task LAV-1782: GRANT/REVOKE/SHOW GRANTS on FUNCTION/PROCEDURE with argument types Parse SHOW GRANTS ON FUNCTION|PROCEDURE <name>(<args>) into a dedicated ShowGrantsOnRoutine AST node that preserves the parenthesised signature, route it to the grant-relation reader keyed on the overload-qualified object name, and reject the parenthesis-less form with the verbatim 090208 (bare routine name). Fix the GRANT OWNERSHIP path to keep the signature in the stored edge, and teach the grants existence check to resolve routines by (name, argument_types). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * task LAV-1782: fix CI — omit routine signature from missing-object grant error --------- Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix CREDENTIALS keyword parsing for redshift
Sample query:
Spec: https://docs.aws.amazon.com/redshift/latest/dg/copy-parameters-authorization.html?utm_source=chatgpt.com