Skip to content

Refactoring StorPool's smoke tests - #7392

Merged
weizhouapache merged 3 commits into
apache:4.18from
storpool:sp-tests-refactoring
Aug 2, 2023
Merged

Refactoring StorPool's smoke tests#7392
weizhouapache merged 3 commits into
apache:4.18from
storpool:sp-tests-refactoring

Conversation

@slavkap

@slavkap slavkap commented Apr 3, 2023

Copy link
Copy Markdown
Contributor

Description

  • removed the hardcoded endpoint of the StorPool primary storage from tests. It should be provided in the configuration file
  • added the git commit information into the maven build. The information is used for monitoring

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale

  • Major
  • Minor

@DaanHoogland DaanHoogland reopened this Apr 4, 2023
DaanHoogland
DaanHoogland reviewed Apr 4, 2023
View reviewed changes
Comment thread plugins/storage/volume/storpool/pom.xml Outdated
@github-advanced-security

github-advanced-security AI commented Apr 4, 2023

Copy link
Copy Markdown

You have successfully added a new SonarCloud configuration ``. As part of the setup process, we have scanned this repository and found no existing alerts. In the future, you will see all code scanning alerts on the repository Security tab.

@shwstppr shwstppr closed this Apr 11, 2023
@shwstppr shwstppr reopened this Apr 11, 2023
@DaanHoogland

DaanHoogland commented Apr 17, 2023

Copy link
Copy Markdown
Contributor

@slavkap , a lot of failures of which it is unclear what caused it,
I'll run smoke tests.

@DaanHoogland

DaanHoogland commented Apr 17, 2023

Copy link
Copy Markdown
Contributor

@blueorangutan package

@blueorangutan

blueorangutan commented Apr 17, 2023

Copy link
Copy Markdown

@DaanHoogland a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan

blueorangutan commented Apr 17, 2023

Copy link
Copy Markdown

Packaging result: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 5921

@blueorangutan

blueorangutan commented Apr 25, 2023

Copy link
Copy Markdown

@DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@DaanHoogland

DaanHoogland commented Apr 28, 2023

Copy link
Copy Markdown
Contributor

@blueorangutan test

@blueorangutan

blueorangutan commented Apr 28, 2023

Copy link
Copy Markdown

@DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@yadvr yadvr closed this May 8, 2023
@yadvr yadvr reopened this May 8, 2023
@yadvr

yadvr commented May 8, 2023

Copy link
Copy Markdown
Member

@blueorangutan package

@blueorangutan

blueorangutan commented May 8, 2023

Copy link
Copy Markdown

@rohityadavcloud a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan

blueorangutan commented May 8, 2023

Copy link
Copy Markdown

Packaging result: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 6039

@sonarqubecloud

sonarqubecloud Bot commented May 8, 2023

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@yadvr yadvr added this to the 4.18.1.0 milestone May 23, 2023
@yadvr yadvr closed this May 23, 2023
@yadvr yadvr reopened this May 23, 2023
@yadvr

yadvr commented May 23, 2023

Copy link
Copy Markdown
Member

@blueorangutan package

@blueorangutan

blueorangutan commented May 23, 2023

Copy link
Copy Markdown

@rohityadavcloud a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@weizhouapache weizhouapache reopened this Jul 28, 2023
@weizhouapache

weizhouapache commented Jul 28, 2023

Copy link
Copy Markdown
Member

@slavkap
could you please fix the build errors ?

@slavkap
slavkap force-pushed the sp-tests-refactoring branch from e367ce7 to 4b8eef4 Compare July 28, 2023 06:54
@slavkap slavkap closed this Jul 28, 2023
@slavkap slavkap reopened this Jul 28, 2023
@slavkap
slavkap force-pushed the sp-tests-refactoring branch from 4b8eef4 to cdc717a Compare July 31, 2023 06:53
@codecov

codecov Bot commented Jul 31, 2023 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #7392 (45c0ba9) into 4.18 (f9b7bcf) will increase coverage by 0.00%.
Report is 9 commits behind head on 4.18.
The diff coverage is 66.66%.

@@            Coverage Diff            @@
##               4.18    #7392   +/-   ##
=========================================
  Coverage     13.02%   13.02%           
- Complexity     9029     9030    +1     
=========================================
  Files          2720     2720           
  Lines        256998   257001    +3     
  Branches      40081    40083    +2     
=========================================
+ Hits          33462    33463    +1     
- Misses       219336   219337    +1     
- Partials       4200     4201    +1
Files Changed Coverage Δ
...va/com/cloud/resourcelimit/CheckedReservation.java 48.83% <0.00%> (ø)
...ervisor/kvm/resource/LibvirtComputingResource.java 18.31% <60.00%> (+0.01%) ⬆️
...om/cloud/hypervisor/kvm/resource/LibvirtVMDef.java 67.13% <100.00%> (ø)
...er/src/main/java/com/cloud/hypervisor/KVMGuru.java 50.81% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@slavkap slavkap closed this Jul 31, 2023
@slavkap slavkap reopened this Jul 31, 2023
slavkap added 3 commits July 31, 2023 13:48
@slavkap
Removed the hardcoded StorPool endpoint from tests
45415ed 
- removed the hardcoded enpoint of StorPool primary storage from tests
- added the git commit information into the maven build
@slavkap
Convert indents to spaces
c0a8287
@slavkap
update git-commit-id-plugin version
45c0ba9
@slavkap
slavkap force-pushed the sp-tests-refactoring branch from cdc717a to 45c0ba9 Compare July 31, 2023 10:49
@DaanHoogland

DaanHoogland commented Jul 31, 2023

Copy link
Copy Markdown
Contributor

@blueorangutan package

@blueorangutan

blueorangutan commented Jul 31, 2023

Copy link
Copy Markdown

@DaanHoogland a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan

blueorangutan commented Jul 31, 2023

Copy link
Copy Markdown

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 6610

@DaanHoogland

DaanHoogland commented Jul 31, 2023

Copy link
Copy Markdown
Contributor

@blueorangutan test matrix

@blueorangutan

blueorangutan commented Jul 31, 2023

Copy link
Copy Markdown

@DaanHoogland a [SF] Trillian-Jenkins matrix job (centos7 mgmt + xenserver71, rocky8 mgmt + vmware67u3, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests

@blueorangutan

blueorangutan commented Jul 31, 2023

Copy link
Copy Markdown

[SF] Trillian Build Failed (tid-7222)

@blueorangutan

blueorangutan commented Aug 1, 2023

Copy link
Copy Markdown

[SF] Trillian test result (tid-7220)
Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7
Total time taken: 38830 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7392-t7220-xenserver-71.zip
Smoke tests completed. 108 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File

@blueorangutan

blueorangutan commented Aug 1, 2023

Copy link
Copy Markdown

[SF] Trillian test result (tid-7221)
Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server r8
Total time taken: 52350 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7392-t7221-vmware-67u3.zip
Smoke tests completed. 107 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File
test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80 Error 615.21 test_internal_lb.py
test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80 Error 615.23 test_internal_lb.py
test_02_internallb_roundrobin_1RVPC_3VM_HTTP_port80 Error 760.11 test_internal_lb.py
test_02_internallb_roundrobin_1RVPC_3VM_HTTP_port80 Error 760.14 test_internal_lb.py

@DaanHoogland

DaanHoogland commented Aug 1, 2023

Copy link
Copy Markdown
Contributor

@blueorangutan test rocky8 vmware-67u3

@blueorangutan

blueorangutan commented Aug 1, 2023

Copy link
Copy Markdown

@DaanHoogland a [SF] Trillian-Jenkins test job (rocky8 mgmt + vmware-67u3) has been kicked to run smoke tests

@blueorangutan

blueorangutan commented Aug 1, 2023

Copy link
Copy Markdown

[SF] Trillian test result (tid-7228)
Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server r8
Total time taken: 45641 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7392-t7228-vmware-67u3.zip
Smoke tests completed. 108 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File

weizhouapache
weizhouapache approved these changes Aug 2, 2023
View reviewed changes

@weizhouapache weizhouapache left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code lgtm

@slavkap this is ready for merge.
have you verified this test on your local environment ? just to confirm

@slavkap

slavkap commented Aug 2, 2023

Copy link
Copy Markdown
Contributor Author

Hi @weizhouapache, yes, the changes have been tested in our lab.

@weizhouapache

weizhouapache commented Aug 2, 2023

Copy link
Copy Markdown
Member

Hi @weizhouapache, yes, the changes have been tested in our lab.

Thanks @slavkap
Merging

@weizhouapache
weizhouapache merged commit da7fc72 into apache:4.18 Aug 2, 2023
DaanHoogland added a commit that referenced this pull request Aug 3, 2023
@DaanHoogland
Merge release branch 4.18 to main
7ee697f 
* 4.18:
  UI: allow new keys for VM details (#7793)
  Refactoring StorPool's smoke tests (#7392)
  UI: decode userdata in EditVM dialog (#7796)
  packaging: unalias cp before package upgrade (#7722)
  make NoopDbUpgrade do a systemvm template check (#7564)
  UI unit test: fix expected values (#7792)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DaanHoogland DaanHoogland DaanHoogland left review comments
@yadvr yadvr yadvr approved these changes
@weizhouapache weizhouapache weizhouapache approved these changes

Assignees

No one assigned

Labels

component:build component:integration-test component:primary-storage component:storage Python Warning... Python code Ahead!

Projects

None yet

Milestone

4.18.1.0

Development

Successfully merging this pull request may close these issues.

7 participants

@slavkap @github-advanced-security @DaanHoogland @blueorangutan @yadvr @weizhouapache @shwstppr