Skip to content

simulator: use ubuntu 22.04 in Dockerfile - #6978

Merged
DaanHoogland merged 2 commits into
apache:mainfrom
weizhouapache:4.18-docker-ubuntu22
Jan 12, 2023
Merged

simulator: use ubuntu 22.04 in Dockerfile#6978
DaanHoogland merged 2 commits into
apache:mainfrom
weizhouapache:4.18-docker-ubuntu22

Conversation

@weizhouapache

Copy link
Copy Markdown
Member

Description

This PR updates the docker image for ubuntu 20.04 to ubuntu 22.04.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

@weizhouapache weizhouapache reopened this Jan 9, 2023
@weizhouapache
weizhouapache marked this pull request as ready for review January 9, 2023 11:53
@sonarqubecloud

sonarqubecloud Bot commented Jan 9, 2023

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@DaanHoogland DaanHoogland left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm

@weizhouapache

Copy link
Copy Markdown
Member Author

I have built a docker image and uploaded to my private repo:
https://hub.docker.com/layers/ustcweizhou/cloudstack-simulator/4.18.0.0-snapshot-20230111/images/sha256-50a044c61138c5b9f1693d709adc07de49f3a7622cb8f6dbddd6ac4111f99294?context=repo

I have created a docker container from the image, everything looks good

image

image

@weizhouapache
weizhouapache requested a review from yadvr January 11, 2023 22:34
@DaanHoogland DaanHoogland added this to the 4.18.0.0 milestone Jan 12, 2023
@DaanHoogland

Copy link
Copy Markdown
Contributor

going out on a limb as this doesn´t get much attention: you can see the results in https://hub.docker.com/r/ustcweizhou/cloudstack-simulator/tags?page=1&name=4.18

@DaanHoogland
DaanHoogland merged commit 4418574 into apache:main Jan 12, 2023
@DaanHoogland
DaanHoogland deleted the 4.18-docker-ubuntu22 branch January 12, 2023 11:54
@yadvr

yadvr commented Jan 12, 2023

Copy link
Copy Markdown
Member

Late to the party but LGTM. We can ask ASF infra to allow us pushing latest simulator built to docker hub via a Github Action on main branch or 4.* tags. cc @DaanHoogland @weizhouapache @davidjumani

@weizhouapache

Copy link
Copy Markdown
Member Author

@rohityadavcloud
yes, I have finished the POC, it worked
please check https://github.com/weizhouapache/cloudstack-new/actions/workflows/docker-cloudstack-simulator.yml

(docker images are automatically uploaded to my private repository https://hub.docker.com/repository/docker/ustcweizhou/cloudstack-simulator/general)

we need to ask ASF Infra to add repository secrets as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants