CAMEL-14929: Changes S3Object manipulation to avoid consume large S3 into memory - #4274
CAMEL-14929: Changes S3Object manipulation to avoid consume large S3 into memory#4274avaz wants to merge 3 commits into
Conversation
…ry and consume it as stream instead.
oscerd
left a comment
There was a problem hiding this comment.
Can you please add unit tests by using localstack approach? It should be pretty easy to test all the combinations. Thanks.
oscerd
left a comment
There was a problem hiding this comment.
And the javadoc you changed must be changed at javadoc level on the s3 configuration class, after the first build the table will be regenerated.
|
@avaz any news? |
|
Hi @oscerd , TL;DR I couldn't add tests using the localstack due the fact that localstack test seems to interact with camel in a different way, essentially the functional class the I made the change ( Please, let me know if this is enough or if possible provide some guidance on how to implement the same tests using localstack. I would expect if I copy and paste the tests from the integration test class to the localstack class would as is. Another thing is that I didn't is about the java docs, where they are generated and what kind of build I run to generate them? So far I'm run |
|
The endpoint is used anyway, so I don't know why in the test with localstack should not be used. Do you have docker running? By the way, the Pr is enough. For the javadoc, you need to do clean install -DskipTests, btw I'll do that once I merge. Thanks |
|
Thanks, merged on master. |
This PR addresses CAMEL-14929 which the goal is to give an option to do not only consume S3 objects into the memory and let the S3Object open so them can be manipulated by the next steps in the pipeline.
With such behaviour is possible to process large S3 objects in a more memory friendly fashion (streaming).