Skip to content

[Go SDK] Replace deprecated reflect.PtrTo in schema test - #40544

Merged
Abacn merged 1 commit into
apache:masterfrom
Eliaaazzz:go-schema-test-pointerto
Oct 13, 2026
Merged

Abacn merged 1 commit into
apache:masterfrom
Eliaaazzz:go-schema-test-pointerto

Conversation

@Eliaaazzz

Copy link
Copy Markdown
Contributor

Follow-up to #40153. @Abacn pointed out in #40153 (comment) that reflect.PtrTo has been deprecated since Go 1.22. The test added there now calls reflect.PointerTo, and the two functions behave identically.

Part of #39684.

@Abacn Abacn left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@codecov

codecov Bot commented Oct 13, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 28.62%. Comparing base (76f6e6d) to head (1effd7b).
⚠️ Report is 141 commits behind head on master.

Additional details and impacted files
@@              Coverage Diff              @@
##             master   #40544       +/-   ##
=============================================
- Coverage     56.16%   28.62%   -27.55%     
=============================================
  Files          1124      380      -744     
  Lines        178336    70974   -107362     
  Branches       1489        0     -1489     
=============================================
- Hits         100170    20316    -79854     
+ Misses        75645    48819    -26826     
+ Partials       2521     1839      -682     
Flag Coverage Δ
go 28.62% <ø> (-0.52%) ⬇️
java ?
python ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions

Copy link
Copy Markdown
Contributor

Assigning reviewers:

R: @shunping for label go.

This pull request likely touches a core component ("core" label). Please review with scrutiny.

Note: If you would like to opt out of this review, comment assign to next reviewer.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@github-actions
github-actions Bot requested a review from shunping October 13, 2026 02:34
@Abacn
Abacn merged commit a523829 into apache:master Oct 13, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants