Repository navigation
Include OpenTelemetry dependencies in published Dataflow runner POM - #40352
Merged
Merged
Conversation
BeamModulePlugin's custom POM generation only exports the `implementation`
(or `shadow`) and `provided` configurations to the published Maven POM,
omitting `runtimeOnly` dependencies.
Change `opentelemetry-exporter-otlp`, `opentelemetry-extension-autoconfigure`,
and `:sdks:java:extensions:opentelemetry-gcp-auth-extension` from
`runtimeOnly` to `implementation` (with `permitUnusedDeclared`) in
`runners/google-cloud-dataflow-java/build.gradle` so that external Maven/Gradle
consumers of `beam-runners-google-cloud-dataflow-java` receive them transitively
and stage them to Dataflow.
Contributor
Author
|
R: @tvalentyn |
Contributor
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment |
Contributor
Author
|
R: @kennknowles |
kennknowles
approved these changes
Sep 30, 2026
kennknowles
left a comment
kennknowles
left a comment
Member
There was a problem hiding this comment.
OK temporarily until we fix BeamModulePlugin (lines 2202 or approx skip runtimeOnly deps, and are just wrong)
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #40352 +/- ##
============================================
+ Coverage 57.29% 58.62% +1.33%
- Complexity 3696 13819 +10123
============================================
Files 1201 2579 +1378
Lines 194397 270329 +75932
Branches 3889 11212 +7323
============================================
+ Hits 111373 158483 +47110
- Misses 79416 105812 +26396
- Partials 3608 6034 +2426
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BeamModulePluginconstructs the<dependencies>section of published Maven POMs from theimplementation(when unshaded) andprovidedconfigurations, omittingruntimeOnlydependencies.Because
opentelemetry-exporter-otlp,opentelemetry-extension-autoconfigure, and:sdks:java:extensions:opentelemetry-gcp-auth-extensionwere declared asruntimeOnlyinrunners/google-cloud-dataflow-java/build.gradle, they were missing from the publishedbeam-runners-google-cloud-dataflow-javaPOM and not pulled in transitively (or staged to Dataflow) for external users.This PR changes those three dependencies to
implementationwithpermitUnusedDeclaredso they are included in the published POM while satisfying dependency analysis checks.