[Refactor] Unify the main process of amoro service container - #4339
Open
zhoujinsong wants to merge 4 commits into
Open
[Refactor] Unify the main process of amoro service container#4339zhoujinsong wants to merge 4 commits into
zhoujinsong wants to merge 4 commits into
Conversation
zhoujinsong
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
#3670 introduced a new master-slave mode for Amoro. However, many implementations adopted separate code paths for this mode. While this reduced intrusion into the legacy code, it is not conducive to long-term maintenance. This PR refactors the main process of
AmoroServiceContainerto unify the handling logic.Brief change log
How was this patch tested?
Add some test cases that check the changes thoroughly including negative and positive cases if possible
Add screenshots for manual tests if appropriate
Run test locally before making a pull request
Documentation