Fix entity-projection alias in WITH clause causing MATCH to fail - #2544
Open
waterWang wants to merge 1 commit into
Open
Fix entity-projection alias in WITH clause causing MATCH to fail#2544waterWang wants to merge 1 commit into
waterWang wants to merge 1 commit into
Conversation
When a vertex variable is renamed via an entity-projection alias in a WITH clause (e.g. WITH n AS alias0), a subsequent MATCH (alias0) failed with "variable 'alias0' already exists". The alias was created as a target-list entry but no transform_entity was registered for the alias name, so find_variable could not find it. Fix: in transform_cypher_node, when te != NULL && entity == NULL but the variable is visible as a column from a previous clause (colNameToVar returns non-NULL), return the column reference directly instead of erroring. The caller creates the transform_entity, allowing subsequent clauses to reference the aliased variable. Fixes apache#2538
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix entity-projection alias in WITH clause causing MATCH to fail
When a vertex variable is renamed via an entity-projection alias in a WITH
clause (e.g. WITH n AS alias0), a subsequent MATCH (alias0) failed with
"variable 'alias0' already exists". The alias was created as a target-list
entry but no transform_entity was registered for the alias name, so
find_variable could not find it.
Fix: in transform_cypher_node, when te != NULL && entity == NULL but the
variable is visible as a column from a previous clause (colNameToVar
returns non-NULL), return the column reference directly instead of
erroring. The caller creates the transform_entity, allowing subsequent
clauses to reference the aliased variable.
Fixes #2538