fix: preserve workspace when session kill teardown fails - #444
Open
baladithyab wants to merge 1 commit into
Open
baladithyab wants to merge 1 commit into
baladithyab wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #440.
When workspace removal fails, session kill has already recorded terminal intent and torn down the runtime. Treat the remaining worktree as preserved instead of returning an opaque 500 that can strand the session as exited but non-terminated. Unexpected teardown failures remain observable through the daemon warning log.
Regression coverage asserts that an arbitrary workspace teardown failure returns
freed=false, preserves the worktree, destroys the runtime, and leaves the session terminated.Verified with: