fix(stats): paginate sync aggregates - #50198
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Production data stopped refreshing after September 19 at 20:17 UTC. The weekly geography query now returns more than R2 SQL's 10,000-row limit, aborting every hourly sync.
Type of change
What does this PR do?
Page usage and geography aggregates with a cursor over their unique dimension keys. Apply pagination after aggregation to preserve distinct counts, averages, and geography totals. Keep the row-limit guard for queries without a cursor, and fail the sync if any page fails.
How did you verify your code works?
27 stats-core tests pass, including real SQLite pagination at 0, 9,999, 10,000, 10,001, and 20,005 rows, cursor escaping, and later-page failure handling. Stats core/server typechecks, formatting, and
git diff --checkpass. A read-only production replay recovered all 10,865 weekly geography rows exactly once; its summed request count matched an independent aggregate query. Repository-wide local typechecking also passed.Checklist